[serverless] upload r2r artifacts to azure #6543
Conversation
but not in the release artifacts
duncanista
added
area:builds
Datadog ReportBranch report: ✅ 0 Failed, 162645 Passed, 535 Skipped, 2h 52m 26.67s Total Time |
| x64-r2r: | ||
| baseImage: centos7 | ||
| managedBaseImage: debian | ||
| artifactSuffix: linux-x64-r2r | ||
| useNativeSdkVersion: true |
There was a problem hiding this comment.
I'm pretty certain you don't need to do this. The tracer is a native binary, so r2r doesn't make any sense 🤔 Plus you don't actually want to use the profiler in the lambda layer anyway AFAIK?
There was a problem hiding this comment.
Yeah, I'm just trying to figure out where I should update so the pipeline package-x goes through, but it might be a good idea to package it just in case – still trying to figure it out
| - task: DownloadPipelineArtifact@2 | ||
| displayName: Download linux x64 r2r packages | ||
| inputs: | ||
| artifact: linux-packages-linux-x64-r2r | ||
| path: $(Build.ArtifactStagingDirectory) |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6543) - mean (68ms) : 66, 71
. : milestone, 68,
master - mean (68ms) : 66, 71
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (6543) - mean (976ms) : 952, 1000
. : milestone, 976,
master - mean (976ms) : 954, 999
. : milestone, 976,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6543) - mean (108ms) : 105, 110
. : milestone, 108,
master - mean (107ms) : 105, 109
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6543) - mean (675ms) : 663, 687
. : milestone, 675,
master - mean (677ms) : 662, 692
. : milestone, 677,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6543) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 89, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6543) - mean (630ms) : 614, 646
. : milestone, 630,
master - mean (636ms) : 621, 652
. : milestone, 636,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6543) - mean (194ms) : 189, 198
. : milestone, 194,
master - mean (193ms) : 189, 198
. : milestone, 193,
section CallTarget+Inlining+NGEN
This PR (6543) - mean (1,099ms) : 1068, 1130
. : milestone, 1099,
master - mean (1,099ms) : 1072, 1126
. : milestone, 1099,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6543) - mean (277ms) : 273, 281
. : milestone, 277,
master - mean (277ms) : 272, 283
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6543) - mean (872ms) : 834, 911
. : milestone, 872,
master - mean (872ms) : 843, 900
. : milestone, 872,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6543) - mean (267ms) : 262, 272
. : milestone, 267,
master - mean (267ms) : 264, 270
. : milestone, 267,
section CallTarget+Inlining+NGEN
This PR (6543) - mean (844ms) : 810, 877
. : milestone, 844,
master - mean (851ms) : 822, 880
. : milestone, 851,
|
…s' of ssh://github.com/DataDog/dd-trace-dotnet into jordan.gonzalez/r2r/add-r2r-artifacts-to-azure-pipelines
Summary of changes
Makes sure ReadyToRun artifacts are uploaded to azure, but not published as artifacts.
Reason for change
We need to release a new .NET Lambda Layer, and this is blocking it, as the release pipeline doesn't trigger properly in gitlab, this will allows us to grab the artifacts from a release directly from the Azure pipeline.
Implementation details
Updated Azure pipeline to upload those artifacts, and made sure the gitlab script was using that on release tags.
Test coverage
Manual
Other details